empty list on getBlobEntries #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 90.64% 90.51% -0.13%
==========================================
Files 19 20 +1
Lines 556 559 +3
==========================================
+ Hits 504 506 +2
- Misses 52 53 +1
|
Affie
requested changes
May 3, 2023
There was a problem hiding this comment.
An empty list works on my side:
julia> getBlobEntries(fgclient, :x2)
BlobEntry[]What you are checking is part of the clearer error messages not implemented yet. I didn't see it as a high enough priority and thought we could do it at a later stage.
In other words: Your check should still error with a message that the variable does not exist.
|
As for moving the blob store structs, I'm fine with that as long as the constructors are kept with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.